[Webkit-unassigned] [Bug 111591] [EFL][WK2] Separate WebView further from EwkView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111591





--- Comment #21 from Caio Marcelo de Oliveira Filho <cmarcelo at webkit.org>  2013-03-15 07:24:34 PST ---
(From update of attachment 193263)
View in context: https://bugs.webkit.org/attachment.cgi?id=193263&action=review

> Source/WebKit2/UIProcess/API/C/efl/WKView.cpp:35
> +    WKPageSetUseFixedLayout(webView->pageRef(), true);

I think this shouldn't be here.

> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:273
> +    // Remove when possible.

It was pointed out in other review. Add a "FIXME: " here.

> Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:65
> +    m_view = WKViewCreate(context, pageGroup);
> +    m_window = ewkCreateEvasObject(m_view, ecore_evas_get(m_backing), /* smart */ 0);

My suggestion was more in the line of having this code written as:

    m_window = ewkCreateWebView(context, pageGroup, ecore_evas_get, /* smart */ 0);
    m_view = ewkGetWKView(m_window); // Note that this do not transfer ownership.
    // or having an ewkGetWKPage().

In other hands, when using EWK, we use a create function specific of EWK that will call WKViewCreate (and possibly set WKPageSetUseFixedLayout() and friends.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.