[Webkit-unassigned] [Bug 107207] [V8] Support selectively wrapping DOM accesses from certain V8 contexts.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107207





--- Comment #30 from Dan Carney <dcarney at google.com>  2013-03-15 00:35:51 PST ---
(In reply to comment #24)
> (In reply to comment #21)
> > (From update of attachment 191857 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=191857&action=review
> > 
> > > Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:81
> > > +static void weakReferenceCallback(v8::Isolate* isolate, v8::Persistent<v8::Value> value, void* dataPtr)
> > 
> > We have a new mechanism for making weak callbacks typesafe.  We should probably use that here now.
> 
> what is that mechanism?
> 
> > 
> > > Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:85
> > > +    value.Dispose(isolate);
> > 
> > We usually call value.Clear after disposing the handle.  I'm not sure it actually does much though.
> 

clear() should not be called on the handle passed back in the callback but on the original handle.  either way it's pretty irrelevant here as your data objects will remain strongly reachable by the objecttemplate and never be called back.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.