[Webkit-unassigned] [Bug 112275] TextIterator emits LF for a br element inside an empty input element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112275


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #193167|review?                     |review-
               Flag|                            |




--- Comment #10 from Ryosuke Niwa <rniwa at webkit.org>  2013-03-14 12:04:05 PST ---
(From update of attachment 193167)
View in context: https://bugs.webkit.org/attachment.cgi?id=193167&action=review

> Source/WebCore/editing/TextIterator.cpp:753
>      // br elements are represented by a single newline.
>      RenderObject* r = node->renderer();

While we're at it, please rename r to renderer, and remove this comment that repeats the self-evident fact.

> Source/WebCore/editing/TextIterator.cpp:755
> +    // Checking if this node is a <br> element within a shadow tree of an input element.

This comment repeats the code. Please remove it.

> Source/WebCore/editing/TextIterator.cpp:756
> +    bool isNodeInsideInputShadowTree = node->isInShadowTree() && node->shadowHost()->toInputElement();

The boolean shouldn't be a question. Rename it to nodeIsInsideInputElement.

> LayoutTests/editing/text-iterator/basic-iteration-expected.txt:20
> +PASS range.selectNodeContents(shadow); internals.rangeAsText(range) is "b"
> +PASS range.selectNodeContents(shadow); internals.rangeAsText(range) is "b"
> +PASS range.selectNodeContents(shadow); internals.rangeAsText(range) is ""
> +PASS range.selectNodeContents(shadow); internals.rangeAsText(range) is "\n"