[Webkit-unassigned] [Bug 112354] [BlackBerry] Resolves 3 WebGL conformance suite crashes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112354





--- Comment #4 from Jonathan Feldstein <jfeldstein at rim.com>  2013-03-14 09:08:00 PST ---
(In reply to comment #2)
> (From update of attachment 193130 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=193130&action=review
> 
> > Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:427
> > +            sizeofChannels *= 1;
> 
> I guess this is not needed. Maybe the compiler does not generate the instructions though.
> 
> > Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:454
> > +            sizeofChannels *= 1;
> 
> Ditto.

You're definitely correct that it's needless. I was trying to be more clear about what's going on. Perhaps I could add case statements which simply break immediately without doing a multiply. Is that a fair compromise?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.