[Webkit-unassigned] [Bug 112088] Correct impl-side scrolling for RTL iframe and overflow:scroll

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 14 07:49:51 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=112088





--- Comment #8 from Sami Kyöstilä <skyostil at chromium.org>  2013-03-14 07:52:16 PST ---
I'm surprised to see there isn't more fallout from changing the RenderLayer's scroll coordinate system like this.

View in context: https://bugs.webkit.org/attachment.cgi?id=192828&action=review

> Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:251
> +        webLayer->setScrollPosition(IntPoint() + (scrollableArea->scrollPosition() - scrollableArea->minimumScrollPosition()));

Nit: I find toPoint() a little more concise than this but both work.

> Source/WebCore/rendering/RenderLayer.cpp:2539
> +    return IntPoint() + m_scrollOffset;

With this change this method is equivalent to scrolledContentOffset. Do we need both?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list