[Webkit-unassigned] [Bug 112276] Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112276


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #193031|                            |review-
               Flag|                            |




--- Comment #7 from chris fleizach <cfleizach at apple.com>  2013-03-13 19:14:46 PST ---
(From update of attachment 193031)
View in context: https://bugs.webkit.org/attachment.cgi?id=193031&action=review

you also need a layout test. see LayoutTests/platform/mac/accessibility/search-predicate something or other for an example of using this functionality

> Source/WebCore/ChangeLog:5
> +        https://bugs.webkit.org/show_bug.cgi?id=112276

no new line between title and link

> Source/WebCore/ChangeLog:6
> +

add description of what this patch does

> Source/WebCore/ChangeLog:7
> +        Reviewed by Chris Fleizach

don't put my name here, leave it as blank

> Source/WebCore/accessibility/AccessibilityObject.cpp:115
> +bool AccessibilityObject::isAccessibilityObjectSearchKeyMatch(AccessibilityObject* axObject, AccessibilitySearchKey searchKey, AccessibilityObject *startObject)

* is in wrong place for startObject

> Source/WebCore/accessibility/AccessibilityObject.cpp:256
> +        if (isAccessibilityObjectSearchKeyMatch(axObject, criteria->searchKeys->at(i), criteria->startObject))

you should pass in the index of the search key criteria instead of breaking up the criteria like this. that will be less churn overall.
so i imagine the method would take, axObject, criteria, searchKeyIndex

using the at() method is not necessary, you should be able to do searchKeys[i]

> Source/WebCore/accessibility/AccessibilityObject.h:315
> +    Vector<AccessibilitySearchKey> *searchKeys;

i don't think you need to make a pointer out of this. it can just be a Vector<>
then you can make a constructor that takes in the other objects and just use the Vector<> that you get out of the criteria

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3190
> +            size_t length = (size_t)[(NSArray *)searchKeyEntry count];

i think you'll do less casting if you leave this as a NSUINteger and then just do one static_cast<size_t> in reserveInitialCapacity

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3192
> +            for (size_t i = 0; i < length; ++i) {

i should be a NUINteger because it's used to access obejctAtIndex: which expects that type

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.