[Webkit-unassigned] [Bug 107207] [V8] Support selectively wrapping DOM accesses from certain V8 contexts.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107207





--- Comment #21 from Adam Barth <abarth at webkit.org>  2013-03-13 17:19:08 PST ---
(From update of attachment 191857)
View in context: https://bugs.webkit.org/attachment.cgi?id=191857&action=review

> Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:81
> +static void weakReferenceCallback(v8::Isolate* isolate, v8::Persistent<v8::Value> value, void* dataPtr)

We have a new mechanism for making weak callbacks typesafe.  We should probably use that here now.

> Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:85
> +    value.Dispose(isolate);

We usually call value.Clear after disposing the handle.  I'm not sure it actually does much though.

> Source/WebCore/bindings/v8/V8DOMCoverWrapping.cpp:97
> +    const V8DOMCoverWrapping::ClosureData dataContents = {0, method, 0, 0};
> +    V8DOMCoverWrapping::ClosureData* instance = new V8DOMCoverWrapping::ClosureData(dataContents);

This is a strange way of creating a V8DOMCoverWrapping::ClosureData object.  Why do we have the const one?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.