[Webkit-unassigned] [Bug 112275] TextIterator emits LF for a br element inside an empty input element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112275


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #193011|review?                     |review-
               Flag|                            |




--- Comment #8 from Ryosuke Niwa <rniwa at webkit.org>  2013-03-13 16:02:11 PST ---
(From update of attachment 193011)
View in context: https://bugs.webkit.org/attachment.cgi?id=193011&action=review

Look at tests inside LayoutTests/editing/text-iterator.

> Source/WebCore/editing/TextIterator.cpp:756
> +        return node->hasTagName(brTag) && !node->isInShadowTree() && !node->shadowHost()->toInputElement();

This is wrong. Being inside a shadow tree doesn't imply that the shadow tree is inside an input element.

>> Source/WebCore/editing/TextIterator.cpp:758
>>      return r->isBR();
> 
> Should I do a similar check here using node? I am not familiar what RenderObject means.

Yes. Having a renderer means that the node nor its ancestors don't have display: none.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.