[Webkit-unassigned] [Bug 109404] Add selectTrailingWhitespaceEnabled setting to WebCore::Page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109404





--- Comment #50 from Manuel Rego Casasnovas <rego at igalia.com>  2013-03-13 14:49:47 PST ---
(In reply to comment #33)
> (From update of attachment 191944 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=191944&action=review
> 
> > Source/WebKit/chromium/src/EditorClientImpl.cpp:110
> >  #if OS(WINDOWS)
> >      return true;
> >  #else
> 
> I would remove this if-def and return false if I were you since it shouldn't matter what we return in that case.
> 
> > Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:248
> > +        return true;
> 
> This should return false.

Ok, this 2 explicit issues were already fixed in the current patches.

However, as we talked by IRC you were also asking about the "return true;" in all the smartInsertDeleteEnabled() methods in the EditorClients of every port.

I'm going to change it in a new patch for "return false;" as I agree with you that it doesn't matter and returning true has not too much sense. I just did it initially because of they were the default values, but that's already defined in Settings.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.