[Webkit-unassigned] [Bug 112191] [v8] Binding Integrity should move off of vtable checks.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112191





--- Comment #8 from Adam Barth <abarth at webkit.org>  2013-03-13 13:18:51 PST ---
(From update of attachment 192977)
View in context: https://bugs.webkit.org/attachment.cgi?id=192977&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2020
> -    V8DOMWrapper::associateObjectWithWrapper(impl.release(), &V8${interfaceName}::info, wrapper, args.GetIsolate(), WrapperConfiguration::Dependent);
> +    V8DOMWrapper::associateObjectWithWrapper(impl.release().get(), &V8${interfaceName}::info, wrapper, args.GetIsolate(), WrapperConfiguration::Dependent);

impl.release().get()   <---  This is the same as impl.get()

> Source/WebCore/bindings/v8/NPV8Object.cpp:54
> -    static WrapperTypeInfo typeInfo = { 0, 0, 0, 0, 0, 0, 0, WrapperTypeObjectPrototype };
> +  static WrapperTypeInfo typeInfo = { 0, 0, 0, 0, 0, 0, 0, WrapperTypeObjectPrototype, 0 };

bad indent?

> Source/WebCore/bindings/v8/ScriptWrappable.h:71
> +   void setTypeInfo(const WrapperTypeInfo* info)

bad indent

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.