[Webkit-unassigned] [Bug 111701] Basic child obscuration test for backgrounds

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 13 09:32:04 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=111701





--- Comment #28 from Darin Adler <darin at apple.com>  2013-03-13 09:34:28 PST ---
(From update of attachment 192860)
View in context: https://bugs.webkit.org/attachment.cgi?id=192860&action=review

> Source/WebCore/rendering/RenderBox.h:595
> +    bool backgroundIsOpaqueInRect(const LayoutRect& localRect) const;
> +    virtual bool backgroundIsObscured() const;

For functions like these, the question I always ask is what they return when the answer is “I don’t know” or “it’s too complicated to compute”. I think in both cases, the function returns true when it’s sure the answer is true, and false when it’s either false or unsure.

I wish we could come up with names are still short but that make that more explicit and clear.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list