[Webkit-unassigned] [Bug 112143] [BlackBerry] GraphicsLayer: fix code that was accidentally reverted

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 13 00:36:25 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=112143





--- Comment #3 from Alberto Garcia <agarcia at igalia.com>  2013-03-13 00:38:50 PST ---
(In reply to comment #2)
> (From update of attachment 192724 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=192724&action=review
> 
> > Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:-810
> > -        return;
> 
> Do we need this kind of check for m_layer? Or is it guarenteed to be non-null?

m_layer is initialized in the constructor so it's guaranteed to always
have a value.

There's actually a check in GraphicsLayerBlackBerry::willBeDestroyed()
that we should be able to remove:

    if (m_layer)
        m_layer->setOwner(0);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list