[Webkit-unassigned] [Bug 111688] Web Inspector: Details of InjectedScript function call shall not be linkified in Timeline panel.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111688





--- Comment #9 from pdeng6 <pan.deng at intel.com>  2013-03-12 18:58:25 PST ---
(In reply to comment #7)
> (From update of attachment 192652 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=192652&action=review
> 
> > Source/WebCore/inspector/front-end/TimelinePresentationModel.js:1127
> > +     * @return {true|false}
> 
> {boolean}
> 
Done

> > Source/WebCore/inspector/front-end/TimelinePresentationModel.js:1133
> > +                var parsedURL = new WebInspector.ParsedURL(this.scriptName);
> 
> You can make use of String.prototype.asParsedURL found in ParsedURL.js and rewrite this as:
> 
> this._validScriptLocation = !!this.scriptName.asParsedURL();
> 
Done, thanks a lot for guidance!

> > Source/WebCore/inspector/front-end/TimelinePresentationModel.js:1135
> > +            } else {
> 
> Please remove curly braces around a single-line block.
> 
Done

> > Source/WebCore/inspector/front-end/TimelinePresentationModel.js:1140
> > +        return  this._validScriptLocation;
> 
> Extraneous whitespace after "return"
Done,

Thanks!
Pan

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.