[Webkit-unassigned] [Bug 112160] [GTK] Add webkit_uri_request_get_http_headers to WebKit2 GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112160


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andersca at apple.com,
                   |                            |benjamin at webkit.org




--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-03-12 10:03:24 PST ---
(In reply to comment #2)
> (From update of attachment 192756 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=192756&action=review
> 
> Great stuff! Now we just need the owner stamp.

Thanks! Adding owners to CC.

> > Source/WebKit2/UIProcess/API/gtk/WebKitURIRequest.cpp:157
> > + *    or %NULL if @request is not an HTTP request.
> 
> Maybe it would be slightly more accurate to say "if @request is not a #WebKitURIRequest." ?

Nope, we can create a WebKitURIRequest for a non HTTP URI, there's a test case in the unit tests that checks this returns NULL for a file:// URI request.

> > Source/WebKit2/UIProcess/API/gtk/WebKitURIRequest.cpp:169
> > +    request->priv->httpHeaders.set(soup_message_headers_new (SOUP_MESSAGE_HEADERS_REQUEST));
> 
> A space snuck in after soup_message_headers_new.

I wonder why the style checker didn't catch this one.

> > Source/WebKit2/UIProcess/API/gtk/tests/TestLoaderClient.cpp:351
> > +    // Load a request with no do not track header.
> 
> Really tiny nitpick: Do Not Track is a proper noun, which isn't a big deal, but it makes this comment easier to read if you capitalize it.

Sure, I'll upload a new patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.