[Webkit-unassigned] [Bug 111688] Web Inspector: Details of InjectedScript function call shall not be linkified in Timeline panel.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111688


Alexander Pavlov (apavlov) <apavlov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #192652|review?                     |review-
               Flag|                            |




--- Comment #7 from Alexander Pavlov (apavlov) <apavlov at chromium.org>  2013-03-12 04:28:01 PST ---
(From update of attachment 192652)
View in context: https://bugs.webkit.org/attachment.cgi?id=192652&action=review

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:1127
> +     * @return {true|false}

{boolean}

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:1133
> +                var parsedURL = new WebInspector.ParsedURL(this.scriptName);

You can make use of String.prototype.asParsedURL found in ParsedURL.js and rewrite this as:

this._validScriptLocation = !!this.scriptName.asParsedURL();

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:1135
> +            } else {

Please remove curly braces around a single-line block.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:1140
> +        return  this._validScriptLocation;

Extraneous whitespace after "return"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.