[Webkit-unassigned] [Bug 112004] Add USE(PLATFORM_STRATEGIES) ifdefs to StorageNamespace.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112004





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-03-12 03:22:19 PST ---
(In reply to comment #3)
> (From update of attachment 192466 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=192466&action=review
> 
> > Source/WebCore/storage/StorageNamespace.cpp:34
> > +#if USE(PLATFORM_STRATEGIES)
> >  #include "PlatformStrategies.h"
> >  #include "StorageStrategy.h"
> > +#else
> > +#include "StorageNamespaceImpl.h"
> > +#endif
> 
> I think that it's best to not add ifdefs around includes, that's just unnecessary extra work.

You are right, PlatformStrategies.h and StorageStrategy.h already have the #if USE(PLATFORM_STRATEGIES), I'll submit a new patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.