[Webkit-unassigned] [Bug 111126] Enable GPU-GPU texture copy in texImage2D() for HTMLVideoElement if hardware accelerated video decode is in use

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111126


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #192373|review?                     |review-
               Flag|                            |




--- Comment #27 from Kenneth Russell <kbr at google.com>  2013-03-11 19:36:34 PST ---
(From update of attachment 192373)
View in context: https://bugs.webkit.org/attachment.cgi?id=192373&action=review

Thanks for your continued work on this. It looks good overall, and the Chromium API change looks fine, but there's a new layering violation that requires one more change.

> Source/WebCore/platform/graphics/MediaPlayer.h:350
> +    bool copyVideoTextureToPlatformTexture(GraphicsContext3D*, WebGLTexture*, GC3Dint level, GC3Denum type, GC3Denum internalFormat, bool premultiplyAlpha, bool flipY);

Code under platform/graphics is not supposed to reference WebCore types outside of platform/graphics like WebGLTexture*. While there are other violations of this rule in this class and in the WebGL implementation, it isn't good to add more. Please change the WebGLTexture* argument to Platform3DObject (defined in GraphicsTypes3D.h).

> Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:781
> +        return false;

Since according to the layering rules the WebGLTexture object won't be available here, please move these checks back up to WebGLRenderingContext.cpp and have them apply to all ports -- they aren't unreasonable restrictions. Also, please document the current restrictions in MediaPlayer.h.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.