[Webkit-unassigned] [Bug 110524] Add a way to watch pages for elements matching a CSS selector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110524





--- Comment #7 from Tony Chang <tony at chromium.org>  2013-03-11 11:59:02 PST ---
(From update of attachment 192328)
View in context: https://bugs.webkit.org/attachment.cgi?id=192328&action=review

We'll want to add a compile time flag for this feature and you'll need to generate a ChangeLog.  I think we can upload for review after that.

> Source/WebCore/dom/Document.h:1176
> +    void addSelectorMatch(String selector);
> +    void removeSelectorMatch(String selector);

Nit: const String& to avoid some refcount churn.

> Source/WebCore/rendering/style/RenderStyle.h:1266
> +    void addCallbackSelector(String selector, Document*);
> +    void removeCallbackSelector(String selector);

Nit: const String&

> Source/WebKit/chromium/tests/WebFrameTest.cpp:298
> +    doc.insertUserStyleSheet("span{-webkit-callback:-webkit-presence !important}",

Is !important necessary in this test case?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.