[Webkit-unassigned] [Bug 112040] [SOUP] ResourceRequest::updateSoupMessage doesn't update the URI of the soup message

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112040





--- Comment #11 from Martin Robinson <mrobinson at webkit.org>  2013-03-11 11:40:24 PST ---
(In reply to comment #10)

> Just unfortunate timing with the comments, I guess. Don't mean to blame anyone.

So my objection to this is follows:

Right now it seems that updateSoupMessage is only called in one place and that's directly after creating the SoupMessage. In this case the SoupMessage will have the URL that it was created with. updateSoupMessage is not meant to be called currently at any other moment. Thus, there's no bug without the other piece of this patch which calls it at a different moment. Thus, this patch just added effectively redundant code that doesn't make sense except in tandem with the next piece.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.