[Webkit-unassigned] [Bug 112040] [SOUP] ResourceRequest::updateSoupMessage doesn't update the URI of the soup message

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 11 11:14:25 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=112040





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-03-11 11:16:50 PST ---
(In reply to comment #2)
> Does this break something or just for completeness? This code is really fragile, so I wouldn't change it without a new test passing.

I think this hasn't been noticed before because in most of the cases the soup message has been created with a URI that is still valid after calling updateSoupMessage. I'm currently implementing SoupMessageHeaders *webkit_uri_request_get_http_header() in WebKit2, and I've switched the WebKitURIRequest to wrap a SoupMssage. When the WebKitURIRequest is created from a ResourceRequest the URI is not updated, and since it's a construct property, the default value remains (about:blank).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list