[Webkit-unassigned] [Bug 111859] [qt] Webkit fails to compile if EGL headers are not in default INCLUDEPATH

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111859





--- Comment #11 from Floris Bos <bos at je-eigen-domein.nl>  2013-03-11 10:58:42 PST ---
> If all the EGL calls we need can be linked at compile time through normal 
>library linking, I think that we should keep it that way as long as possible.

Well, I'm not sure if all ARM devices have OpenGL ES/EGL libraries installed at all.
Some vendors might not supply GPU accelerated ones, and having ones doing software rendering makes little sense on such slow CPUs.

Naturally, if you are creating a build for a specific device, 3D functionality can simply be disabled at compile time.
But it would be nice if generic Linux/ARM distributions could provide a single generic QtWebkit package that works on multiple devices, and resorts to disabling 3D functionality at runtime if libEGL is not present.


>I didn't want to bother you with this, so we can just push this patch and we'll >fix the rest later, but the best way to fix this would be to remove those lines >from WebCore.pri:
>
>> win32: {
>> ...
>> } else {
>>     contains(QT_CONFIG, opengles2): LIBS += -lEGL
>> }


Do you mean just the non-win32 EGL section, or including the win32 section dealing with OpenGL libs?
Linking OpenGL libs there should not be necessary if shims take care of that at runtime, but do not have a Windows box to test on.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.