[Webkit-unassigned] [Bug 109422] [Qt] Add Page Visibility API support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 11 06:35:00 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=109422





--- Comment #32 from Simon Hausmann <hausmann at webkit.org>  2013-03-11 06:37:25 PST ---
(From update of attachment 192436)
View in context: https://bugs.webkit.org/attachment.cgi?id=192436&action=review

> Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:160
> +void QWebPageAdapter::setPageVisible(bool visible)

Since this function doesn't actually make the page visible or not (in the graphical sense of it) but just changes the state, I suggest to call it just like the WebCore::Page function: setVisibilityState

> Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.h:247
> +    void setPageVisible(bool);

This looks much neater :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list