[Webkit-unassigned] [Bug 96592] Ruby text is incorrectly positioned when its writing-mode is changed to vertical after layout is done
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 11 05:07:53 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=96592
--- Comment #17 from Yuki Sekiguchi <yuki.sekiguchi at access-company.com> 2013-03-11 05:10:18 PST ---
Hi Morrita-san,
Thank you for reviewing.
(In reply to comment #15)
> (From update of attachment 191920 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=191920&action=review
> > Source/WebCore/ChangeLog:8
> > + Fix logical left of RenderRubyText is not cleared.
>
> s/Fix/Fixed/ - WebKit usually uses past tense here.
>
> > Source/WebCore/ChangeLog:10
> > + This cause trouble when RenderRubyTest is laid out as vertical after as horizontal.
>
> s/causes/
> s/as vertical/vertically/
> s/as horizontal/horizontally/
Fixed.
> > Source/WebCore/ChangeLog:13
> > + RenderRubyText::y remain old one.
>
> You should explain not only what the problem was, but also how you fixed it.
Added the description of how to fix.
> > LayoutTests/ChangeLog:8
> > + Add a test that change block flow direction of Ruby after layout.
>
> You don't need any extra description in this case. This is kinda obvious.
OK. Removed.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list