[Webkit-unassigned] [Bug 110717] [EFL] Consolidate defaults for feature flags

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110717





--- Comment #8 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2013-03-10 22:26:40 PST ---
(From update of attachment 192389)
View in context: https://bugs.webkit.org/attachment.cgi?id=192389&action=review

LGTM otherwise.

> Source/cmake/OptionsEfl.cmake:7
> +EXEC_PROGRAM("gcc -E -P -dM -DBUILDING_EFL__ -I ${CMAKE_SOURCE_DIR}/Source/WTF ${CMAKE_SOURCE_DIR}/Source/WTF/wtf/Platform.h | grep '^#define ENABLE_\\w\\+ [01]$\\|^#define WTF_USE_\\w\\+ [01]$' | cut -d' ' -f2-3 | sort" OUTPUT_VARIABLE DEFINITIONS)

As we talk on irc, I think it would be good to move to WebKitHelpers.cmake when other ports want to use this command.

> Source/cmake/OptionsEfl.cmake:63
>  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCESSIBILITY ON)

It looks Bug 110291 was cloased. So, I wonder how to move this feature definitions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.