[Webkit-unassigned] [Bug 105180] [GTK] When the WebProcess crashes, a signal should be emitted

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105180





--- Comment #28 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-03-10 00:12:48 PST ---
(From update of attachment 192354)
View in context: https://bugs.webkit.org/attachment.cgi?id=192354&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1304
> +     */

You should document here the return value of the signal.

Returns: %TRUE to stop other handlers from being invoked for the event. %FALSE to propagate the event further.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:2945
> +gboolean webkitWebViewWebProcessCrashed(WebKitWebView* webView)

Do we need to return the signal result? I think this is only useful for the event propagation.

> Source/WebKit2/UIProcess/API/gtk/tests/TestWebExtensions.cpp:48
> +static gboolean webProcessCrashedCallback(WebKitWebContext* context, WebViewTest* test)

This should be WebKitWebView, not WebKitWebContext. We can omit the parameter name since it's unused.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.