[Webkit-unassigned] [Bug 111708] SegmentedString copy constructor is 1% of total time for background html parser?

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 9 13:12:14 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=111708





--- Comment #6 from Eric Seidel <eric at webkit.org>  2013-03-09 13:14:39 PST ---
I tried changing to use a Deque with inline capacity 2, but that just causes VectorBuffer::swap to be hot.  Presumably from:

    template<typename T, size_t inlineCapacity>
    inline Deque<T, inlineCapacity>& Deque<T, inlineCapacity>::operator=(const Deque<T, inlineCapacity>& other)
    {
        // FIXME: This is inefficient if we're using an inline buffer and T is
        // expensive to copy since it will copy the buffer twice instead of once.
        Deque<T, inlineCapacity> copy(other);
        swap(copy);
        return *this;
    }

I suspect there is a way to get what HTMLSourceTracker wants w/o the malloc, I just have to study what it's trying to do more.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list