[Webkit-unassigned] [Bug 111891] Can't build w/o accelerated compositing due to Source/WebCore/dom/PseudoElement.cpp:69:5: error: 'pseudoElementDestroyed' is not a member of 'WebCore::InspectorInstrumentation'

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 9 02:58:38 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=111891





--- Comment #7 from Dean Jackson <dino at apple.com>  2013-03-09 03:01:02 PST ---
(From update of attachment 192341)
The change itself is fine, but you need to do a few more things in order to get a patch accepted. You can read most of this on the wiki:
http://trac.webkit.org/wiki
e.g. http://trac.webkit.org/wiki/CodeReview

Considering this is fixing a build and thus might be urgent, I'll land the patch and upload it here for you to look at.

BTW - I'm not sure why you changed from the first patch. I liked having the #ifdef in one place.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list