[Webkit-unassigned] [Bug 111708] SegmentedString copy constructor is 1% of total time for background html parser?

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111708





--- Comment #4 from Eric Seidel <eric at webkit.org>  2013-03-09 02:06:41 PST ---
I added some logging, it looks like in parsing the whole of teh HTML5 spec, we only copy Deque from this callsite 10 times or so?  That makes me very surprised to see it be 2% of total time, as I did in my sample just now (other parts of gotten faster since I filed this bug).

Not sure what's up.  It's possible my methods are flawed.

I'll try changing Deque<SegmentedSubstring> m_substrings to use an inline capacity of 2 tomorrow and see if that makes things faster.  I worry since SegmentedSubstring can't be copied with memcpy, that will just shift the slowness elsewhere.

It's not immediately clear to me why HTMLSourceTracker needs to do this copying in the first place. :(

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.