[Webkit-unassigned] [Bug 103644] [GTK] Split GtkAuthenticationDialog in two widgets

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103644





--- Comment #14 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-03-09 01:00:36 PST ---
(In reply to comment #13)
> I don't see anything that could hurt the project. I sign off on this for WebKit2.
> 
> > It can be used. We switched long time ago to use only the internal API, because the code is a lot simpler, to avoid unnecessary casts and memory allocations in some cases. We didn't know this was a problem for Apple, I've always considered the C API as public for wk users not for the ports, and we indeed expose both APIs, so that WebKitGTK+ users can use the GTK+ high level API or the C API directly. Switching back to use the C API now would be a lot of work and we are currently at the end of our release cycle.
> 
> I don't have a strong opinion regarding using the C API or not for all ports.
> 
> What I care about is:
> 1) correctness and testing.
> 2) hackability.
> 
> The nice thing I see about the recent move from everyone to the C API, is we have a common ground for testing: the WK C API. Anything exposed there can/should be tested by solid API tests.

Well, in most of the cases the C API methods are just wrappers around an internal method, without any other logic, so it's not that relevant for testing purposes. We use the C API clients to receive the events. The C API is also fully tested by WTR and the TestWebKitAPI tests.

> Ports can have extra layers of tests on top (and I think all of them do now), but the common base is covered by common tests.

Indeed, unit tests are very important for us, and we don't accept patches adding new API without a solid unit test exercising the API. 

> That being said, I dislike the C API as the interfacing layer. I wish WebKit2 did not grow into this giant mess such that the C API is considered a good idea :(

Agree, we decided to switch also because in the last contributors meeting it was said that the C API was going to be removed or replaced by a C++ API at some point.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.