[Webkit-unassigned] [Bug 111892] equalIgnoringCase should take a const StringImpl* instead of StringImpl*

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111892





--- Comment #6 from Benjamin Poulain <benjamin at webkit.org>  2013-03-09 00:04:50 PST ---
I think we just need new objects for the threaded cases. I have a couple of ideas for free conversion of that kind but I never got the time to look into it :( :(

I am a fan of TBB-like structure. I wish we had started by adding something like that.


> We considered (and I'm still interested in) not using *Names globals at all, but for now we have these (somewhat hackish and definitely fragile) threadSafeMatch calls for the threaded parser to use.

For the *Names globals, I can make their StringImpl thread safe for the cases you need. This will take quite a bit of work because of something I care about on ARM, which is why I haven't looked into it yet. If that makes your life easier, I can bump it a bit in my list of priorities.


(In reply to comment #5)
> I'm not sure I'm going to actually fix this.  StringImpl.h is full of non-const StringImpl* arguments.  It seems to be the intentional style for that file?  I can sympathize with the desire to not spread the const disease.  And as ap/benp allude to, the current solution is not really ideal for the threaded parser.

I don't see any good reason for the missing const. I assume it is just an oversight.
I think it would be good to fix this regardless of the threaded parser issues.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.