[Webkit-unassigned] [Bug 110524] Add a way to watch pages for elements matching a CSS selector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110524


Jeffrey Yasskin <jyasskin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #189861|0                           |1
        is obsolete|                            |




--- Comment #6 from Jeffrey Yasskin <jyasskin at chromium.org>  2013-03-08 20:10:17 PST ---
Created an attachment (id=192328)
 --> (https://bugs.webkit.org/attachment.cgi?id=192328&action=review)
Patch adding a -webkit-callback CSS property

* WebVector::resize() is used by WTF::copyToVector in FrameLoaderClientImpl::selectorMatchChanged().

* I didn't try moving {add,remove}CallbackSelector to ElementRareData because I believe it wouldn't save any storage: since RenderStyles can be shared between elements, I'd have to save the selector list from StyleResolver into the RenderStyle anyway in order to propagate it to the Elements.

* Re checking client() for NULL, everything in FrameLoaderClientImpl does that, so I think it's needed.

* Other style comments are addressed, I think.

* I ran this through a couple pagecyclers and saw a fairly consistent ~3% slowdown. Moving the destruction behavior from ~RenderStyle to ~StyleRareNonInheritedData and moving the current StyleRule* from an argument to applyProperty into m_state resolved that slowdown.

* I've added a test, too.

Is there anything else you'd like me to do before this is ready for review?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.