[Webkit-unassigned] [Bug 110375] Add client callbacks to notify of changes of associated from controls

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 8 14:37:00 PST 2013


--- Comment #81 from Dane Walllinga <dgwallinga at chromium.org>  2013-03-08 14:39:24 PST ---
(From update of attachment 191811)
View in context: https://bugs.webkit.org/attachment.cgi?id=191811&action=review

>> Source/WebCore/ChangeLog:5
>> +        are dynamically created, autofill can know to re-query the autofill server and keep going.
> As I pointed out on my previous comment, this long description of the patch should be below "Reviewed by" line followed by a blank line.
> Just look at other change log entries.


>> Source/WebCore/ChangeLog:10
>> +        No new tests.
> You should remove this line or explain why there is no new test.

Is there testing that would be appropriate for this change? Shouldn't affect any layout stuff, and from what I can tell, WebKit isn't big on ordinary unit tests.

>> Source/WebCore/dom/Document.cpp:6088
>> +    this->frame()->page()->chrome()->client()->didAssociateFormControls(m_associatedFormControls);
> We don't need this->, do we?


>> Source/WebKit/chromium/src/ChromeClientImpl.cpp:1156
>> +        elementVector[i] = WebNode(*it);
> So sad we can't use copyToVector :(

I'll take your word for it.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list