[Webkit-unassigned] [Bug 111670] Implement pinch zoom for bottom-right fixed-position elements

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 8 13:57:48 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=111670





--- Comment #6 from Tien-Ren Chen <trchen at chromium.org>  2013-03-08 14:00:11 PST ---
(In reply to comment #5)
> (From update of attachment 191901 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=191901&action=review
> 
> > Source/Platform/chromium/public/WebLayer.h:199
> > +    virtual void setFixedToRightEdge(bool) { }
> 
> I wonder if we should have something more like the bitfields in the ViewportConstraints instead of this? That'll also cover cases where a layer is fixed to both edges on the same axis, in which case we may want to do something special in the compositor.

I think you're right. I was too lazy to write a WebViewportConstraint. Will do.

> > Source/WebCore/rendering/RenderLayerCompositor.cpp:1921
> > +RenderObject* RenderLayerCompositor::requiresFixedToContainerByRenderObject(const RenderLayer* layer) const
> 
> This function name is kinda hard to parse. Maybe fixedToContainerByRenderObject? The description doesn't seem to match the implementation since we can also return the layer itself (so the RenderObject won't be between the layer and its nearest compositor ancestor).

Yep... The range is actually [this, compositing ancestor)
The semantic is to return false if the layer doesn't need fixed position compensation, and true if it does, and if true also returns which RenderObject caused it.
I'll change the function name and refine the comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list