[Webkit-unassigned] [Bug 109404] Add selectTrailingWhitespaceEnabled setting to WebCore::Page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109404





--- Comment #39 from Manuel Rego Casasnovas <rego at igalia.com>  2013-03-08 13:26:23 PST ---
(In reply to comment #38)
> (From update of attachment 192163 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=192163&action=review
> 
> > Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:-417
> > -    m_smartInsertDeleteEnabled = true;
> > -#ifdef WIN32
> > -    m_selectTrailingWhitespaceEnabled = true;
> > -#else
> > -    m_selectTrailingWhitespaceEnabled = false;
> > -#endif
> 
> The Chromium test failures are because Chromium DRT has these default values, which are different from the Chromium browser defaults.  Calling the setter methods in the tests that failed will cause Chromium Win to probably fail some tests.  E.g., editing/pasteboard/smart-paste-00[78].html have different platform results (these tests are from before the testrunner methods setSmartInsertDeleteEnabled and setSelectTrailingWhitespaceEnabled when we had different baselines per platform).

Yes, I understand it. I didn't realized that the defaults for DRT and browser are different.

> I am sorry this is so complicated.

Don't worry and thank you very much for taking care of reviewing it. I understand that as Chromium port doesn't use the default values, things gets more complicated.

> I think the right thing to do for chromium is in Tools/DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp, add these defaults in applyTo().

Ok, I'll provide a patch reverting the changes in the tests my last patch and setting the defaults in WebPreferences.cpp.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.