[Webkit-unassigned] [Bug 105180] [GTK] When the WebProcess crashes, a signal should be emitted

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 8 10:14:56 PST 2013


--- Comment #24 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-03-08 10:17:20 PST ---
(From update of attachment 192206)
View in context: https://bugs.webkit.org/attachment.cgi?id=192206&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1305
> +    signals[WEB_PROCESS_CRASHED] = g_signal_new("web-process-crashed",

I usually move also the first parameter to the next line so that all parameters are lined up.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1308
> +        0, 0, 0,

You should use G_STRUCT_OFFSET(WebKitWebViewClass, web_process_crashed),
Also maybe we could make this true handled, and if not handled by the user we can show a default crashed page like we do for error pages. For now we could just make this true handled without a default implementation and add it later.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list