[Webkit-unassigned] [Bug 111513] Create a script to import W3C tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 7 19:17:52 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=111513





--- Comment #10 from Dirk Pranke <dpranke at chromium.org>  2013-03-07 19:20:17 PST ---
Okay, so here's an initial round of feedback ...

1. r- at the very least to add the copyright info

2. as we discussed on #irc, I think we should merge these two scripts. I don't think that users necessarily should need to be aware of the need to generate manifest files.

3. ideally, this should work for anything in (at least) the CSSWG repo (by which I am referring to http://hg.csswg.org/test). I don't know if something broke in the patch you just uploaded, but it seems like I can't even run these scripts over the approved/css3-background dir that I could with the first patch. Should this work over the whole repo?

4. I think we'll need to get some sort of consensus on webkit-dev over how we want to import test suites before we land this and start importing things. If we have different people importing different sub directories into different parts of the tree, keeping things up to date could get very painful (we'd need to build a mapping of w3c directory to webkit directory somewhere).

I'm kinda thinking maybe we should try to put all of the tests in the entire csswg repo under LayoutTests/w3c/csswg or something.

Another potential option (with fairly obvious downsides) would be to actually clone or mirror the repo somewhere (either under LayoutTests/w3c or someplace outside of LayoutTests altogether).

Since these are kind of two parallel discussions, what I'd like to do is assume a strawman process for purposes of "importing" the tests such that we can run NRWT over them, but *not actually plan to check in imported tests yet*.

That way we can make progress on the import scripts and the code reviews while we debate the higher-level process.

Sound good? I'm open to other approaches, but I'm probably not going to be a fan of landing these scripts so that we can import individual directories in an ad-hoc / manual way in the mean time.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list