[Webkit-unassigned] [Bug 92868] [css3-text] Add platform support for "wavy" text decoration style

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92868


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin at webkit.org




--- Comment #54 from Benjamin Poulain <benjamin at webkit.org>  2013-03-07 16:27:21 PST ---
> > As an alternative, why not 'strokeWavyTextDecoration(GraphicsContext* context, const FloatPoint& point1, const FloatPoint& point2)'?
> > 
> > +don't const the input float;
> 
> Why not const them?

This: "const float strokeThickness)" is not the WebKit convention.

> > Instinctively, I would have used bezier curve. Why do you use straight lines?
> 
> Well, I am not used to use bezier curves. Also, we deciced to make this curse to look similar to mozilla's implementation [1]. There is also some performance concerns about using strokPath to implement wavy stroke [2], would bezier curve improve performance here?
> 
> [1] https://bugs.webkit.org/show_bug.cgi?id=94110#c16
> [2] https://bugs.webkit.org/show_bug.cgi?id=93507#c43

I don't really care about Mozilla's implementation if we can make ours looks better! :)

I doubt a bezier path would improve performance. On a good rasterizer, that will not change performance too much.
It is probably worth testing and comparing the two.

> I can use change it to a switch-case, but it would look like this
> 
> [...]

Verbose is good. Take the one with the best readability.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.