[Webkit-unassigned] [Bug 98270] [GTK][WK2] Add API to retrieve a snapshot from a webview

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98270





--- Comment #38 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-03-07 08:16:05 PST ---
(From update of attachment 191994)
View in context: https://bugs.webkit.org/attachment.cgi?id=191994&action=review

>> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:2996
>> +                                                           reinterpret_cast<gpointer>(webkit_web_view_get_snapshot));
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]

You need to adopt the ref. Also fix the style issues, please

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:3019
> + * Returns: (transfer full): a #cairo_surface_t with the retrieved snapshot

or %NULL in case of error

> Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp:1123
> +static gboolean compare_cairo_surfaces(cairo_surface_t* s1, cairo_surface_t* s2)

Sorry I didn't notice this before, this should be 

bool compareCairoSurfaces(). 

But compare functions usually return 0, <0 or >0. This just returns whether they are equal or not so I would use cairoSurfacesEqual() or something like that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.