[Webkit-unassigned] [Bug 105180] [GTK] When the WebProcess crashes, a signal should be emitted

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 7 01:13:59 PST 2013


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #191675|review?                     |review-
               Flag|                            |

--- Comment #22 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-03-07 01:16:23 PST ---
(From update of attachment 191675)
View in context: https://bugs.webkit.org/attachment.cgi?id=191675&action=review

After looking at the implementation I've changed my mind, and I think it's better to move the signal to the web view. It will make the api easier to use. And for the download case, we can always add the signal to WebKitDownload, to notify the download that the web process crashed.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:838
> +void webkitWebContextWebProcessCrashed(WebKitWebContext* context)
> +{
> +    g_signal_emit(context, signals[WEB_PROCESS_CRASHED], 0);
> +}

This is very problematic in the end, because we are emitting the signal in the context but for every web page.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list