[Webkit-unassigned] [Bug 101857] Updating mouse cursor on style changes without emitting fake mousemove event

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101857





--- Comment #123 from Aivo Paas <aivopaas at gmail.com>  2013-03-06 13:51:08 PST ---
Sorry, I did not mean to offend you. It's just that many of the weaknesses you pointed out, were not my original ideas, but suggestions by others or based on the code that was already there. Not the warmest welcome a first time helping hand would hope for.

> > Source/WebCore/page/EventHandler.cpp:1282
> > +    if (node && originalIsText)
> > +        node = node->parentNode();
> 
> This call to parentNode is new code. Why does this change need to be made? Does it improve something?

I completely forgot about that. It was added when the timer was not used and instead hovered state was checked to only call updateCursor() on hovered nodes. Now that this is reverted and timer still used, this check is no longer needed. I will clean it up and then the refactored code should look almost exactly like the original.

I'll also go over the other other bits that were pointed out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.