[Webkit-unassigned] [Bug 111591] [EFL][WK2] Separate WebView further from EwkView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111591





--- Comment #5 from Mikhail Pozdnyakov <mikhail.pozdnyakov at intel.com>  2013-03-06 11:55:02 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=191794&action=review

> Source/WebKit2/UIProcess/API/efl/EwkView.h:102
> +    static EwkView* create(WebKit::WebView*, Evas* canvas, PassRefPtr<EwkContext> context, Evas_Smart* smart = 0);

Not sure about it. So far we have evas object that owns ewkview and ewkview owns webview, at least it is clearly determined how all 
those objects are created and deleted. Now it becomes more complicated.. like if WKViewCreateEvasObject was invoked web view memory management is done one way and if WKViewCreateEvasObject wasn't invoked it should be done totally different.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:94
> +    return o;

o?

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:97
> +static Evas_Object* internal_add_with_context(Evas* canvas, Ewk_Context* context, Evas_Smart* smart)

createView? createEvasObject?

> Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:109
> +    WKViewSetThemePath(wkView, WKStringCreateWithUTF8CString(TEST_THEME_DIR "/default.edj"));

adopt

> Source/WebKit2/UIProcess/efl/WebView.cpp:77
> +{

assertion here?

> Source/WebKit2/UIProcess/efl/WebView.cpp:288
> +    if (!m_ewkView)

think assertion is enough here. WebView will own its focus state after bug110877 is fixed.

> Source/WebKit2/UIProcess/efl/WebView.cpp:296
> +    if (!m_ewkView)

ditto

> Tools/TestWebKitAPI/efl/PlatformWebView.cpp:69
> +    WKViewSetThemePath(m_view, WKStringCreateWithUTF8CString(THEME_DIR "/default.edj"));

adopt?

> Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:67
> +        WKPageSetUseFixedLayout(WKViewGetPage(m_view), true);

that is great that we use WKPageSetUseFixedLayout and drop this annoying ViewBehavior, I guess it could be done even as a separate patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.