[Webkit-unassigned] [Bug 111074] REGRESSION(r141450): failed ASSERT in FrameView::scheduleRelayout()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111074


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #191168|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #9 from Darin Adler <darin at apple.com>  2013-03-06 09:43:04 PST ---
(From update of attachment 191168)
View in context: https://bugs.webkit.org/attachment.cgi?id=191168&action=review

review- because this is too mysterious to do without a comment, and is probably not exactly the right fix

> Source/WebCore/page/FrameView.cpp:2061
> +    if (!frame()->view())
> +        return;

The strange thing about this is that we could add a check like this to all FrameView functions. We need a rule to tell us which ones need this. It’s particularly important because you are not contributing a test for this, so no one would be able to tell functions that need this kind of check from functions that don’t.

Further, it’s non-obvious why taking a round trip to check for null is the right thing here. This needs a comment, not just the code, because it’s non-obvious. Further, maybe it should be a check for frame()->view() == this instead of frame()->view() being non-null.

What’s special about contentsResized that means this is needed? Maybe the check belongs at the caller instead of inside this function?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.