[Webkit-unassigned] [Bug 110487] Ctrl+Shift+Right in Windows should select the spacing after the word

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110487





--- Comment #37 from Claudio Saavedra <csaavedra at igalia.com>  2013-03-05 12:12:49 PST ---
(In reply to comment #36)
> (From update of attachment 190658 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=190658&action=review
> 
> > Source/WebCore/editing/FrameSelection.cpp:609
> > +        if (directionOfEnclosingBlock() == LTR) {
> > +#if PLATFORM(MAC)
> >              pos = nextWordPosition(pos);
> > -        else
> > +#else
> > +            bool skipsSpaceWhenMovingForward = m_frame && m_frame->editor()->behavior().shouldSkipSpaceWhenMovingRight();
> > +            pos = nextWordPosition(pos, skipsSpaceWhenMovingForward);
> > +#endif
> 
> I don't want to see all these if-defs here.

I am not sure how to implement a version of findNextWordFromIndex() for mac that would take into account whether spaces should be skipped or not. The existing method seems to use NSAttributedString attributes. Since Mac doesn't follow the Windows behavior, this doesn't seem absolutely mandatory, but if some dev from the Mac port is kind enough to jump in we might not need the ifdef's.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.