[Webkit-unassigned] [Bug 111434] [GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111434





--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-03-05 08:30:34 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> 
> > In this particular case it's not possible, webkit_web_context_set_favicon_database_directory() can only be called once, and it has to be called first. We could do it in beforeAll() but then, not-initialized test wouldn't work. We are using a temp favison database so that the tests don't affect the user favicon database, the test that clears the database has to run the last one, or we would need to fill it again. I think this is the only case and the patch is simple enough.
> 
> Perhaps put that test into an afterAll() section?

In afterAll() get_test_run() has finished, you can't add tests there. And that wouldn't make the other tests cases independent from each other so I don't see why that's better than just using the same test suite name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.