[Webkit-unassigned] [Bug 110584] [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110584





--- Comment #12 from Krzysztof Czech <k.czech at samsung.com>  2013-03-05 07:08:57 PST ---
(In reply to comment #10)
> (From update of attachment 190023 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=190023&action=review
> 
> The patch looks good to me overall. Just a comment on the change in the TestExpectations file, see it below
> 
> > LayoutTests/ChangeLog:8
> > +        Unskipping LayoutTests/accessibility folder.
> 
> I think this is not 100% accurate, since you're unskipping the folder, but skipping some tests anyway in an individual basis.
Yes, it may sound inaccurate.
> 
> Also, I wonder whether it would not be better for the EFL port to mark those tests as "Failures" instead of just skipping them, so you can easily realize when they start passing in the bots.
Sounds good.
I added failure ones and skipped only those with missing expected results.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.