[Webkit-unassigned] [Bug 83681] [GTK] Add WebKitWebPage::send-request signal to WebKit2 GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83681





--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-03-05 01:43:42 PST ---
(In reply to comment #11)
> (From update of attachment 190719 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=190719&action=review
> 
> Looks good to me. :)
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitURIRequest.cpp:133
> > + * Set the URI of @request
> 
> I still think it would be good here to say explicitly that this will only affect the request in the send-request signal handler.

Not necessarily, you could change the uri to reuse a request object to be loaded with webkit_web_view_load_request. We could say that this won't have any effect for a request already sent to the server, for example, or something like that, but I think it's pretty obvious.

> > Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp:625
> > +    events = test->m_loadEvents;
> 
> I don't think you need to set this reference again actually.

You are right

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.