[Webkit-unassigned] [Bug 110355] Get rid of "non-composited contents" in CoordinatedLayerTreeHost

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110355





--- Comment #6 from Huang Dongsung <luxtella at company100.net>  2013-03-04 15:47:55 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> You can probably fix this one by changing CoordinatedLayerTreeHost to call 
>     bool didSync = m_webPage->corePage()->mainFrame()->view()->flushCompositingStateIncludingSubframes();
> before the other flushes.

Yes, your suggestion can be work well! We can go with your suggestion for a while.

But there are two weak points.
1. tree order is broken.
2. there is a subtle reason that it works well although tree order is broken.
Setting children needs tree order traversal, because setting parent also is performed during setting children and relies heavily on tree order traversal.
But your suggestion works well because "m_nonCompositedContentLayer->flushCompositingStateForThisLayerOnly();" does not flush only for this layer, but also flush all layers in this frame by tree order.
It eventually calls FrameView::paintContents and paintContents eventually calls flushCompositingStateForThisFrame. So m_nonCompositedContentLayer and rootLayer of RenderLayerCompositor are involved well with parent-child relation.

It works well because of the subtle reason, so we can go with your suggestion until this bug is resolved.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.