[Webkit-unassigned] [Bug 110612] Enumerating an HTMLCollection needs to enumerate the named properties

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110612





--- Comment #15 from Kentaro Hara <haraken at chromium.org>  2013-03-04 15:40:50 PST ---
(From update of attachment 191095)
View in context: https://bugs.webkit.org/attachment.cgi?id=191095&action=review

Almost LGTM.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2223
> +        if ($interfaceName =~ /^HTML\w*Collection$/) {

We don't want to hard-code interface names in an ad-hoc manner. Can't you use CodeGenerator::InheritsInterface($interface, "HTMLCollection")?

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2626
> +    if ($interfaceName =~ /^HTML\w*Collection$/) {

Ditto.

> Source/WebCore/html/HTMLCollection.cpp:734
> +    for (NodeCacheMap::iterator it = m_nameCache.begin(); it != m_nameCache.end(); ++it)
> +        propertyNameStrings.append(it->key);
> +    for (NodeCacheMap::iterator it = m_idCache.begin(); it != m_idCache.end(); ++it)
> +        propertyNameStrings.append(it->key);

Just to confirm: This order does not matter, right? i.e. The spec does not specify the order of enumeration, right?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.