[Webkit-unassigned] [Bug 83681] [GTK] Add WebKitWebPage::send-request signal to WebKit2 GTK+ API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 4 11:34:32 PST 2013


--- Comment #11 from Martin Robinson <mrobinson at webkit.org>  2013-03-04 11:36:56 PST ---
(From update of attachment 190719)
View in context: https://bugs.webkit.org/attachment.cgi?id=190719&action=review

Looks good to me. :)

> Source/WebKit2/UIProcess/API/gtk/WebKitURIRequest.cpp:133
> + * Set the URI of @request

I still think it would be good here to say explicitly that this will only affect the request in the send-request signal handler.

> Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp:625
> +    events = test->m_loadEvents;

I don't think you need to set this reference again actually.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list