[Webkit-unassigned] [Bug 109061] <link rel="apple-touch-icon"> tag is not honored on CNN.com, workflowy.com etc

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109061





--- Comment #56 from Ryosuke Niwa <rniwa at webkit.org>  2013-03-03 04:01:13 PST ---
(In reply to comment #55)
> Re-opened since this is blocked by bug 111266

The patch caused Apple Windows build failures:

e.g.

19>LINK : C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\bin\DumpRenderTree.dll not found or not built by the last incremental link; performing full link
19>   Creating library C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\lib\DumpRenderTree.lib and object C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\lib\DumpRenderTree.exp
19>WebCoreTestSupport.lib(JSInternals.obj) : error LNK2019: unresolved external symbol "class JSC::JSValue __cdecl WebCore::toJS(class JSC::ExecState *,class WebCore::JSDOMGlobalObject *,class WebCore::CSSStyleDeclaration *)" (?toJS at WebCore@@YA?AVJSValue at JSC@@PAVExecState at 3@PAVJSDOMGlobalObject at 1@PAVCSSStyleDeclaration at 1@@Z) referenced in function "__int64 __fastcall WebCore::jsInternalsPrototypeFunctionComputedStyleIncludingVisitedInfo(class JSC::ExecState *)" (?jsInternalsPrototypeFunctionComputedStyleIncludingVisitedInfo at WebCore@@YI_JPAVExecState at JSC@@@Z)

http://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/63456/steps/compile-webkit/logs/stdio

It wasn’t a simple missing symbol error. It looked like something wasn’t compliling.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.